Serverinfo endpoints are not bruteforce protected nor are tokens properly generated
Low
Vulnerability Details
The serverinfo app allows accessing the endpoints also via a custom token.
https://github.com/nextcloud/serverinfo/blob/9ae9dde028a684e53a1b37c9ba8e964ffe42a97f/lib/Controller/ApiController.php#L121
The token is set/generated via
https://github.com/nextcloud/serverinfo/blob/9ae9dde028a684e53a1b37c9ba8e964ffe42a97f/templates/settings-admin.php#L341
## Impact
There is no bruteforce protection on this endpoint in general. So a attacker can just fire off request. Combine this with that they have to generate a token on their own (which is usually a lot weaker) and in a lot of cases obtaining acccess should not be horribly hard.
I'd recommend
1. Add bruteforce protection to the endpoint
2. Have a button in the UI to generate a proper long random string
Actions
View on HackerOneReport Stats
- Report ID: 1210458
- State: Closed
- Substate: resolved
- Upvotes: 7